Skip to content

V1-Fixes #3738. CursesDriver stops responding.#3739

Merged
tig merged 1 commit intogui-cs:v1_developfrom
BDisp:v1_3738_cursesdriver-stops-responding
Sep 17, 2024
Merged

V1-Fixes #3738. CursesDriver stops responding.#3739
tig merged 1 commit intogui-cs:v1_developfrom
BDisp:v1_3738_cursesdriver-stops-responding

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Sep 16, 2024

Fixes

Proposed Changes/Todos

  • Fix bug in the read method that was reading the second index instead the first in mainloop callback.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner September 16, 2024 14:33
@tig tig merged commit 962d552 into gui-cs:v1_develop Sep 17, 2024
@BDisp BDisp deleted the v1_3738_cursesdriver-stops-responding branch September 17, 2024 16:09
@tomba
Copy link
Copy Markdown

tomba commented Mar 15, 2025

@tig Could a new v1 version be tagged and a nuget package made? Without this fix, a thread will run in busy loop as the pipe always has data to read.

@tig
Copy link
Copy Markdown
Collaborator

tig commented Mar 16, 2025

Yeah. I'll do this asap!

@tig
Copy link
Copy Markdown
Collaborator

tig commented Mar 16, 2025

v1.18.0 has been published!

https://www.nuget.org/packages/Terminal.Gui/

@tomba
Copy link
Copy Markdown

tomba commented Mar 17, 2025

v1.18.0 has been published!

Thanks, works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants