Conversation
C# 12 feature
Just set the object.
Potentially fewer allocations, as well
Bump nuget packages. Tests confirmed still passing.
Should probably be split up into multiple tests or at least have tests added for the individual actions it takes to prove them in isolation.
Assert end is identical to start Also use the OperationManager so the state of the stacks can be tested
Each part is a local function so it's all easier to visually parse now
…vert-unit-tests-to-constraint-model-5 * 39-convert-statusbartests-to-constraint-model: This one can safely run in parallel Convert this fixture Finishes #39
…to convert-unit-tests-to-constraint-model-5 * 40-convert-stringextensiontests-to-constraint-model: Feed them from TestCaseData collections Convert to constraints Annotate the fixture Finishes #40
…vert-unit-tests-to-constraint-model-5 * 41-convert-tableviewtests-to-constraint-model: Convert, clean up, annotate, and parallelize Finishes #41
Adds tracking the undo/redo stacks and also performs a redo
I think it can go away though
Tests on a couple more subview types, as well
Makes use of the same type provider as the last one
…rt-unit-tests-to-constraint-model-5 * 42-convert-tabviewtests-to-constraint-model: Sort code and add one last missing using statement Convert the last two tests Convert and improve this test Convert and improve this test Convert and improve this test Convert and improve this test Convert and improve this test Clear undo/redo after setting up the base view Use the generic method and add some assumptions for callers of this helper Convert and improve this test Annotations Finishes #42
|
Just a note: Round 6, which is branched from this, is in progress right now, and has had the base v2 branch merged into it, as of a few minutes ago. There weren't even any conflicts, no build errors, and all tests pass. 🥳 So, as of right now, the convert-unit-tests-to-constraint-model-6 branch is equal to v2 here plus everything I've done since the last merged PR. |
|
I have started reviewing this, looks great but have been sidetracked as I test stuff a bit as I have found several new bugs. I will focus on this one as 6 has a bug in resizing (see my comment on that PR). |
|
Yeah I'm thinking the bug in 6 may actually just be that a different pre-existing bug is now being hit, with the fix no longer hiding it. But, I am not certain of that yet - maybe 70% confident, since the tests show hit testing working properly for identifying IsLowerRight when it should and not when it shouldn't. That makes me think something else is calculating it on its own, but I'll have to check it out. I'll work on that before I continue with more conversions. |
2 participants
Opening this one now as a unit, as it contains a few fairly lengthy tests, as well as a couple of TODO notes for potential issues and future work items to address.
A couple of tests did get some pretty significant upgrades, as well as some additional coverage from things like adding additional types/cases to certain tests (more can still be done, but I am more interested in completing the conversion, right now).
This branch is branched from convert-unit-tests-to-constraint-model-4, which is branched from v2 as it was a couple of days ago, after you merged some of your other work and updated the TG reference.
This is of course cumulative with convert-unit-tests-to-constraint-model-4, and they can either be individually merged in order or 4 can be closed and this one merged all at once.
This will stay as-is unless edits are needed. Continued work will be in a new branch, in the same style as the rest (convert-unit-tests-to-constraint-model-6), branched from here.
Ready for merge at any time.