Skip to content

feat!: Highlight timestamp as util.inspect hightlights Dates#23

Merged
phated merged 5 commits intomasterfrom
phated/format-colors
Jan 7, 2022
Merged

feat!: Highlight timestamp as util.inspect hightlights Dates#23
phated merged 5 commits intomasterfrom
phated/format-colors

Conversation

@phated
Copy link
Member

@phated phated commented Dec 27, 2021

This also drops ansi-gray and timestamp in favor of using the platform.

Closes #18 (because they can configure the logging - see README)

@sttk please review! Will this help you support color theme on the timestamp when logging in gulp-cli?

This also drops ansi-gray and timestamp in favor of using the platform.
@phated phated requested a review from sttk December 27, 2021 22:26
@phated phated force-pushed the phated/format-colors branch from e752495 to 0a94838 Compare December 27, 2021 23:07
@phated phated mentioned this pull request Dec 27, 2021
@phated
Copy link
Member Author

phated commented Jan 4, 2022

@sttk please review this when you have some time.

Co-authored-by: contra <yo@contra.io>
sttk
sttk previously requested changes Jan 7, 2022
Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated Sorry for the lay reply. I reviewed this PR and I found a slight mistake.

There is no other problem. Great!

Co-authored-by: Takayuki Sato <sttk.xslet@gmail.com>
@phated phated dismissed sttk’s stale review January 7, 2022 18:58

Merged suggested changes

@phated phated merged commit 27c71a9 into master Jan 7, 2022
@phated phated deleted the phated/format-colors branch January 7, 2022 18:58
@github-actions github-actions bot mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grey colour not visible

3 participants