refactor: remove resolve dependency#47
Open
elliotttf wants to merge 1 commit into
Open
Conversation
This replaces the dependency on resolve with node's native require.resolve method which supports custom paths as of [node 8.9.0](https://nodejs.org/dist/latest-v8.x/docs/api/modules.html#modules_require_resolve_request_options)
elliotttf
added a commit
to elliotttf/knex
that referenced
this pull request
Jun 21, 2024
This replaces the dependency on resolve-from with node's native `require.resolve` method. If this and gulpjs/rechoir#47 are merged, a false positive related to [resolve's `monorepo-symlink-test`](browserify/resolve#312) file will be resolved.
This comment has been minimized.
This comment has been minimized.
|
Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the dependency on resolve with node's native require.resolve method which supports custom paths as of node 8.9.0.
This will address false positive findings related to resolve's
monorepo-symlink-testfile.