Fix handling of thread features for scalars in Anderson2021#7726
Merged
steven-johnson merged 2 commits intohalide:mainfrom Jul 31, 2023
Merged
Fix handling of thread features for scalars in Anderson2021#7726steven-johnson merged 2 commits intohalide:mainfrom
steven-johnson merged 2 commits intohalide:mainfrom
Conversation
Merged
steven-johnson
approved these changes
Jul 31, 2023
Contributor
|
(Oh, and thanks SO much for taking the time to look at this!) |
Contributor
|
This looks like it may have injected #7729 based on a quick bisection -- I thought that |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue in #7699. The cause is that the autoscheduler assumes that every Func is surrounded by a block loop and a thread loop, which means it assumes there is always a non-null
ThreadInfoobject when the features are computed. But in this case, the output of the generator is a single number so the autoscheduler is currently not creating a block and thread loop for it, so the ThreadInfo object ends up being null.The main thing this PR does is add some special cases to
compute_featuresfor handling scalars. It was also necessary to change some function signatures to accept aThreadInfo*instead of aThreadInfo&so that it can test whether the passed object is null or not.