Consider all dimensions before deciding to slide over a new dimension#7875
Merged
TH3CHARLie merged 4 commits intomainfrom Oct 5, 2023
Merged
Consider all dimensions before deciding to slide over a new dimension#7875TH3CHARLie merged 4 commits intomainfrom
TH3CHARLie merged 4 commits intomainfrom
Conversation
Even ones we've already slid over. The previous version of this code could try to slide over a loop where multiple dimensions depend on the loop var, because it ignored dimensions that had already been slid over. Moving a check resolves the issue. Fixes #7872
TH3CHARLie
approved these changes
Oct 5, 2023
Contributor
TH3CHARLie
left a comment
TH3CHARLie
left a comment
There was a problem hiding this comment.
LGTM, waiting the remaining build go green
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…halide#7875) * Don't deduce unreachability from predicated out of bounds stores Fixes halide#7873 * Consider all dimensions before deciding to slide over a new dimension Even ones we've already slid over. The previous version of this code could try to slide over a loop where multiple dimensions depend on the loop var, because it ignored dimensions that had already been slid over. Moving a check resolves the issue. Fixes halide#7872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even ones we've already slid over. The previous version of this code
could try to slide over a loop where multiple dimensions depend on the
loop var, because it ignored dimensions that had already been slid over.
Moving a check resolves the issue.
Fixes #7872