Make wasm +sign-ext and +nontrapping-fptoint the default#7995
Merged
steven-johnson merged 2 commits intomainfrom Dec 8, 2023
Merged
Make wasm +sign-ext and +nontrapping-fptoint the default#7995steven-johnson merged 2 commits intomainfrom
steven-johnson merged 2 commits intomainfrom
Conversation
These have been supported in ~all wasm runtimes for a while now, and +nontrapping-fptoint in particular can make a big performance difference. We should enable these by default, and add a new backdoor (wasm_mvponly) for code paths that need to use the original wasm Minimum Viable Product spec only.
steven-johnson
added
the
release_notes
steven-johnson
added a commit
to halide/build_bot
that referenced
this pull request
Dec 7, 2023
shoaibkamil
approved these changes
Dec 7, 2023
tlively
approved these changes
Dec 7, 2023
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Looks good to me! sign-ext and nontrapping-fptoint have indeed been standard and available for a long time and can give nice codegen improvements.
steven-johnson
added a commit
to halide/build_bot
that referenced
this pull request
Dec 8, 2023
* Update build script to handle halide/Halide#7995 * Update master.cfg * Update master.cfg * Update master.cfg * Update master.cfg
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Make wasm +sign-ext and +nontrapping-fptoint the default These have been supported in ~all wasm runtimes for a while now, and +nontrapping-fptoint in particular can make a big performance difference. We should enable these by default, and add a new backdoor (wasm_mvponly) for code paths that need to use the original wasm Minimum Viable Product spec only. * Update simd_op_check_wasm.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have been supported in ~all wasm runtimes for a while now (see https://webassembly.org/roadmap/), and +nontrapping-fptoint in particular can make a big performance difference. We should enable these by default, and add a new backdoor (wasm_mvponly) for code paths that need to use the original wasm Minimum Viable Product spec only.