Merged
Conversation
It's redundant with the one in LLVM_Headers.h, so all it does is break every time we get a new LLVM version.
alexreinking
approved these changes
Dec 20, 2024
Member
alexreinking
left a comment
There was a problem hiding this comment.
I would prefer to preserve the equivalent version check in CMake because I find it's better to know before you start building anything that you've picked up on the wrong copy of LLVM.
Member
Author
|
Sure. I figured that the Makefile being officially unsupported for third-parties meant that it's fine to remove some hand-holding from it. |
steven-johnson
approved these changes
Dec 20, 2024
Member
Of course! I was just documenting my rationale for not asking you to make the change across both build systems. |
Member
Author
|
Failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's redundant with the one in LLVM_Headers.h, so all it does is break every time we get a new LLVM version.