Skip to content

Remove llvm version check from Makefile#8533

Merged
abadams merged 1 commit intomainfrom
abadams/remove_version_check_from_makefile
Dec 23, 2024
Merged

Remove llvm version check from Makefile#8533
abadams merged 1 commit intomainfrom
abadams/remove_version_check_from_makefile

Conversation

@abadams
Copy link
Member

@abadams abadams commented Dec 20, 2024

It's redundant with the one in LLVM_Headers.h, so all it does is break every time we get a new LLVM version.

It's redundant with the one in LLVM_Headers.h, so all it does is break
every time we get a new LLVM version.
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to preserve the equivalent version check in CMake because I find it's better to know before you start building anything that you've picked up on the wrong copy of LLVM.

@abadams
Copy link
Member Author

abadams commented Dec 20, 2024

Sure. I figured that the Makefile being officially unsupported for third-parties meant that it's fine to remove some hand-holding from it.

@alexreinking
Copy link
Member

Sure. I figured that the Makefile being officially unsupported for third-parties meant that it's fine to remove some hand-holding from it.

Of course! I was just documenting my rationale for not asking you to make the change across both build systems.

@abadams
Copy link
Member Author

abadams commented Dec 23, 2024

Failures unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants