Fix incorrect natural vector size on Zen4#8570
Merged
Conversation
mcourteaux
approved these changes
Feb 10, 2025
Member
Author
|
Looks like the function is marked .func instead of .entry in the ptx now, which results in it being dead-stripped by the ptx compiler. I'll see if I can find out what we're supposed to be doing |
Contributor
Thanks. It's been bugging me for a week now, and I can't do anything about it :P |
Member
Author
|
Oops, I actually meant to leave that comment in your PR, but yeah, it's the same issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.