Conversation
For a long time llvm has been slowly moving to a model where pointers are an opaque type, instead of knowing the pointee type. This has been complete for a while now, so they've started deprecating the APIs for constructing a pointer with a pointee type (these APIs ignore the pointee type anyway), or doing pointer casts, which are no-ops. This PR removes use of those APIs and is a nice simplification of some code.
steven-johnson
approved these changes
Apr 21, 2025
Member
Author
|
It doesn't entirely unbreak it, but the remaining failures are unrelated - some sort of JIT exception handling nonsense on windows, and a bad node.js version or something on the mac x86 bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a long time llvm has been slowly moving to a model where pointers are an opaque type, instead of knowing the pointee type. This has been complete for a while now, so they've started deprecating the APIs for constructing a pointer with a pointee type (these APIs ignore the pointee type anyway), or doing pointer casts, which are no-ops. This PR removes use of those APIs and is a nice simplification of some code.
Hopefully this unbreaks the build for trunk llvm.