remove superfluous overload that causes compile errors

[ongjunjie]

The following code would fail to compile with "ambiguous overloaded function" error. This commit fixes it.

std::vector type = { UInt(8), UInt(8) };
f.define_extern("extern_func", args, type, dims,
                NameMangling::CPlusPlus);

[mcourteaux]

Can you give more details? What is the reason it's ambiguous? Can you give us the compiler error? Can you actually make the code snippet you included correct and complete (define all variables you pass, and define the vector template argument)?

[ongjunjie]

The problem is with the two overloads below. When called as define_extern(std::string, std::vector<ExternFuncArgument>, std::vector<Type>, int, NameMangling), it's ambiguous to the compiler which overload to take and it's treated as an error. The first overload is unnecessary as its functionality is fully defined by the latter.

Halide/src/Func.h

Lines 1167 to 1183 in 08c3357

	void define_extern(const std::string &function_name,
	const std::vector<ExternFuncArgument> &params,
	const std::vector<Type> &types, int dimensionality,
	NameMangling mangling) {
	define_extern(function_name, params, types,
	Internal::make_argument_list(dimensionality), mangling);
	}
	void define_extern(const std::string &function_name,
	const std::vector<ExternFuncArgument> &params,
	const std::vector<Type> &types, int dimensionality,
	NameMangling mangling = NameMangling::Default,
	DeviceAPI device_api = DeviceAPI::Host) {
	define_extern(function_name, params, types,
	Internal::make_argument_list(dimensionality), mangling,
	device_api);
	}

[mcourteaux]

I see. Thanks. LGTM.

[abadams]

Failures are unrelated