Skip to content

Add an underlying type to the halide_buffer_flags to prevent UB in C++ #8690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcourteaux merged 2 commits into from
Aug 1, 2025
Merged

Add an underlying type to the halide_buffer_flags to prevent UB in C++ #8690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc6287
Add an underlying type to the halide_buffer_flags to prevent UB in C+…
mcourteaux Jul 14, 2025
227fdac
Trigger buildbots
mcourteaux Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/runtime/HalideRuntime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,8 +1541,19 @@ typedef struct halide_dimension_t {
} // extern "C"
#endif

typedef enum { halide_buffer_flag_host_dirty = 1,
halide_buffer_flag_device_dirty = 2 } halide_buffer_flags;
#if __cplusplus > 201100L || _MSVC_LANG > 201100L || __STDC_VERSION__ > 202300L
// In C++, an underlying type is required to let the user define their own flag
// values, without those values being undefined behavior when passed around as
// this enum typedef.
#define BUFFER_FLAGS_UNDERLYING_TYPE : uint64_t
#else
#define BUFFER_FLAGS_UNDERLYING_TYPE
#endif
typedef enum BUFFER_FLAGS_UNDERLYING_TYPE {
halide_buffer_flag_host_dirty = 1,
halide_buffer_flag_device_dirty = 2
} halide_buffer_flags;
#undef BUFFER_FLAGS_UNDERLYING_TYPE

/**
* The raw representation of an image passed around by generated
Expand Down
Loading