Drop invalid "in-bounds" GEP for constant offsets#8768
Merged
Conversation
This GEP was not in fact guaranteed to be in-bounds. This was discovered by a failure in the WASM version of correctness_indexing_access_undef after a change to LLVM's LICM declined to hoist part of the computation. LLVM reference: llvm/llvm-project#151492
abadams
approved these changes
Aug 19, 2025
Member
Author
|
This seems to have introduced some new failures. That or LLVM main did. |
Member
|
Looks like it broke one of the vector load tests in simd_op_check_wasm for all tested versions of llvm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This GEP was not in fact guaranteed to be in-bounds. This was discovered by a failure in the WASM version of correctness_indexing_access_undef after a change to LLVM's LICM declined to hoist part of the computation.
LLVM reference: llvm/llvm-project#151492
Drive-by cleanup in
test/generator/CMakeLists.txt.Fixes #8766