-
Notifications
You must be signed in to change notification settings - Fork 237
[bugfix] fix pyproject install and VSA precision test #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @SolitaryThinker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed a bug that prevented clean installations using uv pip install -e . from succeeding. The issue stemmed from an experimental dataset==4.0.0 dependency. My fix involves adjusting the uv configuration within pyproject.toml to ensure that uv can properly resolve package versions, thereby enabling successful installations.
Highlights
- Updated uv configuration: I've added the
index-strategy = "unsafe-best-match"configuration to the[tool.uv]section inpyproject.toml. This change is crucial foruvto correctly resolve dependencies during a clean installation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an installation failure related to an experimental version of the datasets package. It introduces index-strategy = "unsafe-best-match" for uv. While this might solve the immediate issue, this strategy is considered unsafe and can lead to dependency resolution problems in the future. I've provided a comment suggesting a potentially safer alternative, assuming the experimental package is a pre-release.
pyproject.toml
Outdated
|
|
||
| [tool.uv] | ||
| extra-index-url = ["https://download.pytorch.org/whl/cu128"] | ||
| index-strategy = "unsafe-best-match" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using index-strategy = "unsafe-best-match" is generally discouraged as it can lead to unstable dependencies by mixing packages from different indexes. This is a project-wide setting that could cause issues later.
If datasets==4.0.0 is considered "experimental" because it's a pre-release, a safer way to allow uv to find it is by enabling pre-release resolution. This is a more direct and less risky solution.
prerelease = "allow"
Currently a clean install using
uv pip install -e .will fail as we are using experimental dataset==4.0.0Changes:
--unsafe-best-match