Skip to content

Fix for #1849 (PCAN fails when PCAN_ERROR_ILLDATA is read via ReadFD) #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zariiii9003 merged 2 commits into from
Sep 6, 2024
Merged

Fix for #1849 (PCAN fails when PCAN_ERROR_ILLDATA is read via ReadFD) #1850

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec8ac2
When there is an invalid frame on CAN bus (in our case CAN FD), PCAN …
bures Sep 4, 2024
6e7ad06
Fix for ruff error `can/interfaces/pcan/pcan.py:5:1: I001 [*] Import …
bures Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions can/interfaces/pcan/pcan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
PCAN_DICT_STATUS,
PCAN_ERROR_BUSHEAVY,
PCAN_ERROR_BUSLIGHT,
PCAN_ERROR_ILLDATA,
PCAN_ERROR_OK,
PCAN_ERROR_QRCVEMPTY,
PCAN_FD_PARAMETER_LIST,
Expand Down Expand Up @@ -555,6 +556,12 @@ def _recv_internal(
elif result & (PCAN_ERROR_BUSLIGHT | PCAN_ERROR_BUSHEAVY):
log.warning(self._get_formatted_error(result))

elif result == PCAN_ERROR_ILLDATA:
# When there is an invalid frame on CAN bus (in our case CAN FD), PCAN first reports result PCAN_ERROR_ILLDATA
# and then it sends the error frame. If the PCAN_ERROR_ILLDATA is not ignored, python-can throws an exception.
# So we ignore any PCAN_ERROR_ILLDATA results here.
pass

else:
raise PcanCanOperationError(self._get_formatted_error(result))

Expand Down