Skip to content

Conversation

@bessman
Copy link
Contributor

@bessman bessman commented Oct 4, 2019

As an update/alternative to PR #703, this demonstrates how to send a cyclic checksum using existing functionality. Since it does not rely on callbacks, it should be faster than the method in #703.

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #704 into develop will increase coverage by 3.87%.
The diff coverage is 84.65%.

@@             Coverage Diff             @@
##           develop     #704      +/-   ##
===========================================
+ Coverage    65.65%   69.52%   +3.87%     
===========================================
  Files           69       70       +1     
  Lines         6202     6485     +283     
===========================================
+ Hits          4072     4509     +437     
+ Misses        2130     1976     -154

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if #703 takes a different direction this example is still helpful.

@felixdivo felixdivo added this to the 4.0 Release milestone Jan 29, 2020
@felixdivo felixdivo added the docs label Jan 29, 2020
@felixdivo felixdivo merged commit eeb6593 into hardbyte:develop Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants