Check executable path exists before skipping download#2905
Merged
kblok merged 5 commits intohardkoded:masterfrom Feb 16, 2026
Merged
Check executable path exists before skipping download#2905kblok merged 5 commits intohardkoded:masterfrom
kblok merged 5 commits intohardkoded:masterfrom
Conversation
Came across an issue where the output directory existed but the executable didn't exist, so BrowserFetcher skipped the download.
kblok
approved these changes
May 14, 2025
kblok
approved these changes
Jul 15, 2025
kblok
approved these changes
Feb 16, 2026
Member
kblok
left a comment
kblok
left a comment
There was a problem hiding this comment.
LGTM! The fix correctly checks for the executable file instead of just the directory. Updated from master and builds cleanly.
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across an issue where the output directory existed but the executable didn't exist, so BrowserFetcher skipped the download.