Skip to content

feat: refactor message actions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
90-008 merged 2 commits into from
Apr 1, 2022
Merged

feat: refactor message actions #98

90-008 merged 2 commits into from
Apr 1, 2022

Conversation

@ghost
Copy link

@ghost ghost commented Mar 6, 2022

  • actions are in messages rather than in embeds
  • actions have custom info set by a bot to distinguish different actions in the same message
  • buttons do not have data attached - the action's info is used instead
  • text input can have a default value
  • document that users cannot add actions to messages, only bots
  • document that servers must verify that the user is sending somewhat valid data to the bot
  • remove ActionPayload; it is redundant, the only thing that is being sent is a bytes data for all options anyway

bluskript
bluskript requested changes Mar 7, 2022
View reviewed changes
90-008
90-008 requested changes Mar 7, 2022
View reviewed changes
@90-008 90-008 changed the title refactor message actions feat: refactor message actions Apr 1, 2022
@90-008 90-008 merged commit cdbdf39 into chat/invite-events Apr 1, 2022
@90-008 90-008 deleted the spiralw/refactor/actions branch April 1, 2022 23:35
@90-008 90-008 restored the spiralw/refactor/actions branch April 2, 2022 01:09
@90-008 90-008 deleted the spiralw/refactor/actions branch April 2, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@90-008 @bluskript