Skip to content

Display Comment Count in Explorer After Adding Initial Comment #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tudmotu wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Display Comment Count in Explorer After Adding Initial Comment #408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
524099d
Merge branch 'develop' of https://github.com/hasadna/omuni-budget int…
Tudmotu Feb 17, 2014
dfca3a6
Merge branch 'develop' of https://github.com/prjts/openbudgets into d…
Tudmotu Mar 10, 2014
686e728
Fixed issue #395; Add/rm has_comments class on comments update.
Tudmotu Mar 10, 2014
1d3a4e6
Merge branch 'develop' of https://github.com/hasadna/openmuni-budgets…
Tudmotu Mar 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions openbudgets/apps/entities/static/entities/explorer/ui/items-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,26 @@ define([
},
'update:comments' : function (model) {
// bump the number of comments on the item
var $button = this.$element.find('[data-item=' + model.get('id') + ']');
var $button = this.$element.find('[data-item=' + model.get('id') + ']'),
$comment_counter,
comment_count;

// if it's an item from the list and not scope item
if ( $button.length ) {
// set the buttons
$button.find('.item_comment_button')
.text(model.get('comment_count'));
// Get comment count
comment_count = model.get('comment_count');

// Get comment-counter element
$comment_counter = $button.find('.item_comment_button');

// Set current comment count
$comment_counter.text(comment_count);

// Display/hide comment indicator appropriately
if (comment_count > 0)
$comment_counter.addClass('has_comments');
else
$comment_counter.removeClass('has_comments');
}
else {
// it's the scope item so notify the sheet_scope_comments widget
Expand Down