Merged
Conversation
In theory we could use the latest (v0.18.0) version of the x/tools module but that would also bring upgrade of x/sys (transitive dependency of go-cty) from current v0.5.0 and full understanding of implications of that upgrade.
radeksimko
commented
Feb 16, 2024
| 65, 90, 97, 122, 196, 218, 229, 236, | ||
| 10, 170, 181, 183, 186, 128, 150, 152, | ||
| 182, 184, 255, 192, 255, 128, 255, 173, | ||
| 182, 184, 255, 192, 255, 0, 127, 173, |
Member
Author
There was a problem hiding this comment.
I'm not entirely sure about the meaning of this byte slice but my understanding is that it will change even with a single character change in the corresponding Ragel file it is generated from.
Since two lines of license headers are being added there, that would explain this.
radeksimko
commented
Feb 16, 2024
|
|
||
| import "strconv" | ||
|
|
||
| func _() { |
Member
Author
There was a problem hiding this comment.
This was added back in March 2019 to stringer in https://go-review.googlesource.com/c/tools/+/163637 which implies we have just not run stringer ever since it released the first stable version (v0.1.0 was released in January 2021).
I avoided pinning to some unstable old version just for that purpose and picked the latest compatible stable version.
radditude
approved these changes
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix a number of problems:
copywritetool without reflecting the fact they are generated (and that they should get generated with the headers already)go generate ./...implies a dependency on stringer, which is a Go library that can be tracked as such to provide reproducible results.Closes #637
Next step, which I'm expecting to be a separate PR, would be to add some ways of checking for license headers both in the CI and locally, perhaps similar to what we do in
hashicorp/terraform.