services: warn on job submit when job has services but no shutdown_delay#27782
Merged
pkazmierczak merged 15 commits intomainfrom Apr 23, 2026
Merged
services: warn on job submit when job has services but no shutdown_delay#27782pkazmierczak merged 15 commits intomainfrom
pkazmierczak merged 15 commits intomainfrom
Conversation
pkazmierczak
added
theme/task lifecycle
theme/service-discovery
backport/ent/1.10.x+ent
gulducat
reviewed
Apr 2, 2026
gulducat
reviewed
Apr 2, 2026
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
sorry I have another condition to handle 🙃
gulducat
reviewed
Apr 14, 2026
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
I hope these suggestions make more sense than my attempt at englishing?
Co-authored-by: Daniel Bennett <8812489+gulducat@users.noreply.github.com>
Co-authored-by: Daniel Bennett <8812489+gulducat@users.noreply.github.com>
Contributor
Author
|
@gulducat can you take another look? I think I addressed all the comments. |
pkazmierczak
deleted the
f-warn-on-submit-services-but-no-shutdown-delay
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a warning when a job is submitted with services defined and no service at
the task-level has
shutdown_delayset.Resolves #23326
Internal ref: https://hashicorp.atlassian.net/browse/NMD-430