add CommitIndex API#560
Merged
loshz merged 2 commits intohashicorp:mainfrom Jul 10, 2023
niebayes:main
Merged
Conversation
|
|
mkeeler
approved these changes
Jun 27, 2023
Member
mkeeler
left a comment
mkeeler
left a comment
There was a problem hiding this comment.
LGTM. This already is reported in the Stats map and the underlying values are synchronized appropriately so I see no reason why this value shouldn't be exposed with a direct API.
Member
|
@niebayes I think you will need to sign the HashiCorp CLA before this can be merged. |
Contributor
Author
|
@mkeeler Hi, I've completed the signature. |
Contributor
|
@niebayes it looks like you need to run |
Contributor
Author
|
Ok.
Dan Bond ***@***.***> 于2023年7月1日周六 01:48写道：
… @niebayes <https://github.com/niebayes> it looks like you need to run go
fmt api.go as there is a slight formatting issue that's blocking CI.
—
Reply to this email directly, view it on GitHub
<#560 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBF34NRJ3TXFNDSNP2ZPJ3XN4GN3ANCNFSM6AAAAAAZVHER3E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@loshz Hi, I've fixed the formatting issue. |
loshz
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is useful for implementing the read index optimization as described in the Raft paper.