Merged
Conversation
1. Highlight the file in redirections. 2. Be more specific when highlighting certain keywords. 3. Switch to a better syntax token for command options.
(that's also used in Zed's bash highlighting)
…Zed 0.127.3: - remove the workarounds - allow matching operators in `test` and `[` commands again - use @Embedded for command substitutions as the bash extension does
hasit
approved these changes
Mar 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree-sitter code in the newest stable Zed version 0.127.3 has been updated and resolves some issues in the syntax tree and the fish grammar is parsed correctly.
This PR removes the workarounds for the old issues in
highlights.scmand thus makes the queries terse and much cleaner.Also, I changed a few syntax tokens to match the ones of Zed's
bashhighlighting.