Improve code quality: LICENSE, CI, deps, exception handling#1
Merged
Conversation
- Add MIT LICENSE file (2024, universeplayer) - Add GitHub Actions CI workflow with ruff linting on Python 3.9/3.11 - Add missing `openai` package to requirements.txt - Replace 4 overly broad exception handlers in llm_client.py with specific exceptions (ImportError, json.JSONDecodeError, ValueError, requests.RequestException, etc.) - Update README badges: add clickable Python, License, Stars, and CI badges at the top Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml) -- runsrufflinting on push/PR against Python 3.9 and 3.11, catching syntax errors and undefined namesopenai>=1.0.0torequirements.txt(used byAI_interviewer.pyviafrom openai import OpenAI)llm_client.py:except Exception:on import ->except ImportError:except Exception as e:on JSON config parsing ->except (json.JSONDecodeError, ValueError, OSError)except Exception as e:on API key file loading ->except (FileNotFoundError, ValueError, OSError)except Exception as e:on HTTP retry loop ->except (requests.RequestException, ValueError, KeyError)Test plan
pip install -r requirements.txtinstalls all needed packages includingopenaipython -c "from llm_client import LLMClient"still works (no import errors)Generated with Claude Code