Skip to content

feat: support additional repetition options#60

Merged
hedhyw merged 2 commits intohedhyw:mainfrom
ryzheboka:repetitions-support
Dec 8, 2022
Merged

feat: support additional repetition options#60
hedhyw merged 2 commits intohedhyw:mainfrom
ryzheboka:repetitions-support

Conversation

@ryzheboka
Copy link
Contributor

This PR is for the issue #2 . I didn't find how to update the README in a suitable way. I added the repetition options to the docs instead.

@coveralls
Copy link

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3640407510

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3635822557: 0.0%
Covered Lines: 812
Relevant Lines: 812

💛 - Coveralls

Copy link
Owner

@hedhyw hedhyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks! Small comments

Closes #2

@hedhyw hedhyw added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 7, 2022
@hedhyw hedhyw changed the title support additional repetition options feat: support additional repetition options Dec 7, 2022
@ryzheboka ryzheboka force-pushed the repetitions-support branch from 69f00b4 to 152aefd Compare December 7, 2022 15:37
@ryzheboka
Copy link
Contributor Author

Thanks for the review :) I corrected the code according to your suggestions, pushed it, and merged the updated main branch

Copy link
Owner

@hedhyw hedhyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hedhyw hedhyw merged commit b80fbe5 into hedhyw:main Dec 8, 2022
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 3620502144

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3451581651: 0.0%
Covered Lines: 812
Relevant Lines: 812

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants