Merged
Conversation
hchienjo
force-pushed
the
feat/time-parsing-support
branch
2 times, most recently
from
6b956f4 to
0419b82
Compare
| } | ||
|
|
||
| if t == timeType { | ||
| d, err := time.Parse(time.RFC3339, data) |
Member
There was a problem hiding this comment.
Probably worth documenting this expected format in the README, for example here.
hchienjo
force-pushed
the
feat/time-parsing-support
branch
from
0419b82 to
2ad8e86
Compare
hchienjo
force-pushed
the
feat/time-parsing-support
branch
from
2ad8e86 to
015dc06
Compare
skateinmars
approved these changes
Aug 19, 2025
Member
|
I think this is missing the time support in I also think we should support |
Member
|
Non-pointer |
Member
|
Flag support in draft: #101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time parsing commit cherry picked from #96