CORS updated and declarative CORS#11155
Open
tomas-langer wants to merge 7 commits intohelidon-io:mainfrom
Open
CORS updated and declarative CORS#11155tomas-langer wants to merge 7 commits intohelidon-io:mainfrom
tomas-langer wants to merge 7 commits intohelidon-io:mainfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
…ypes that are no longer used. Update changelog.
tomas-langer
force-pushed
the
7631-cors-updates
branch
from
0162dd1 to
f8f1ff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7631
Resolves #10726
Documentation
This PR deprecates existing CORS support (and the
corsmodule).The new approach:
CorsFeatureExisting APIs are mostly deprecated, the CorsPathConfig replaces
CrossOriginConfig(as it is based on builder API).There is one change that should not have impact on function - we now return
204as the "normal" response from pre-flight checks (204 is "No-Content"), as opposed to original 200 ("OK"), as 204 is a better fit.This breaks test in examples, that I will fix together with Declarative CORS example.
Documentation updated (may require a bit more work).
Archetypes are broken, investigating (I want to remove deprecated stuff)