Exclude jakarta.ejb-api#2595
Merged
Merged
Conversation
barchetta
added
2.x
ljnelson
approved these changes
Dec 10, 2020
Member
There was a problem hiding this comment.
Looks good. Will CDI pull this in too? If so you may need to add an exclusion there as well. (See jakartaee/cdi#449 for example.)
romain-grecourt
approved these changes
Dec 10, 2020
Member
Author
CDI 2.0.2 looks OK: https://repo1.maven.org/maven2/jakarta/enterprise/jakarta.enterprise.cdi-api/2.0.2/jakarta.enterprise.cdi-api-2.0.2.pom I also verified the quickstart looks clean after excluding just from interceptor-api. But I do see something in CDI 3.x so we will want to keep an eye out for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the dependencies in the MP quickstart I noticed jakarta.ejb-api (and jakarta.transaction-api). Those are not needed for the quickstart and are being dragged in by jakarta.interceptor-api 1.2.5 that has a dependency on jakarta.ejb-api. That is a bug. See jakartaee/interceptors#31
So we exclude jakarta.ejb-api. Not sure why we didn't do this earlier.