Skip to content

Virtio net#643

Merged
jounathaen merged 9 commits intomainfrom
virtio-net
Apr 30, 2026
Merged

Virtio net#643
jounathaen merged 9 commits intomainfrom
virtio-net

Conversation

@jounathaen
Copy link
Copy Markdown
Member

@jounathaen jounathaen commented Feb 19, 2024

This is a rebase and rework of #536 done by @BaderSZ

Original description:

This a somewhat-functional implementation for virtio-net. I'll follow up with comments, tests and likely a few examples for RustyHermit soon.

Fixes: #1
Fixes: #1162
Fixes: #253

Unsolved/for follow-up issues/prs:

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2024

Codecov Report

❌ Patch coverage is 83.40381% with 157 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.80%. Comparing base (d7d66d0) to head (e37f7c2).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/virtio/net.rs 82.40% 79 Missing ⚠️
src/pci.rs 68.42% 30 Missing ⚠️
src/params.rs 4.34% 22 Missing ⚠️
src/linux/x86_64/kvm_cpu.rs 87.27% 7 Missing ⚠️
src/virtio/pci.rs 84.61% 6 Missing ⚠️
src/linux/x86_64/virtio_device.rs 94.87% 4 Missing ⚠️
src/net/tap.rs 94.80% 4 Missing ⚠️
src/vm.rs 85.00% 3 Missing ⚠️
src/bin/uhyve.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   76.39%   81.80%   +5.40%     
==========================================
  Files          29       33       +4     
  Lines        4266     4874     +608     
==========================================
+ Hits         3259     3987     +728     
+ Misses       1007      887     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jounathaen jounathaen marked this pull request as draft February 19, 2024 16:28
@jounathaen
Copy link
Copy Markdown
Member Author

If I get it right, using virtio-queue basically forces us to use virtio-mem as memory backend. (makes #645 obsolete).

@jounathaen jounathaen force-pushed the virtio-net branch 8 times, most recently from ff445af to abe8633 Compare February 19, 2024 18:10
@BaderSZ
Copy link
Copy Markdown
Contributor

BaderSZ commented Mar 28, 2024

Some bugs were found when it comes to handling BARs: size/mode aren't handled correctly. I'll document progress and fix on BaderSZ#2

Comment thread config.toml Outdated
Comment thread src/virtio/virtqueue.rs Outdated
Comment thread src/virtio/virtqueue.rs Outdated
@jounathaen jounathaen force-pushed the virtio-net branch 6 times, most recently from b254ed9 to 36e21d4 Compare April 22, 2026 16:43
@fogti fogti mentioned this pull request Apr 28, 2026
Comment thread README.md Outdated
@jounathaen jounathaen dismissed n0toose’s stale review April 30, 2026 12:16

I believe all comments are sufficiently addressed now.

@jounathaen jounathaen added this pull request to the merge queue Apr 30, 2026
@jounathaen
Copy link
Copy Markdown
Member Author

FINALLY!

Merged via the queue into main with commit 13fedaa Apr 30, 2026
12 checks passed
@jounathaen jounathaen deleted the virtio-net branch April 30, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/security Concerns security-related behavior, soundness, isolation or reliability. tests Integration and unit-tests verifying Uhyve's behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove tuntap crate Migrate to vm-virtio add basic virtio support

4 participants