Add release schedule metadata to Node.js inventory#1330
Closed
colincasey wants to merge 13 commits intomainfrom
Closed
Add release schedule metadata to Node.js inventory#1330colincasey wants to merge 13 commits intomainfrom
colincasey wants to merge 13 commits intomainfrom
Conversation
schneems
approved these changes
Mar 20, 2026
Contributor
|
I took a stab at implementing this with a slightly different approach #1332 -- mostly to explore a solution that might work well with the |
d829c71 to
e7b648c
Compare
04afe58 to
3cf1df5
Compare
e7b648c to
8f00330
Compare
3cf1df5 to
462ab09
Compare
8f00330 to
d95d124
Compare
This was referenced Mar 26, 2026
f7a0969 to
a0b8407
Compare
a039af8 to
661e2d8
Compare
a0b8407 to
bb2873b
Compare
6d4d80e to
b006d66
Compare
3 tasks
fbc651d to
5fad153
Compare
b006d66 to
7199597
Compare
5fad153 to
0aac35d
Compare
7199597 to
09b78f2
Compare
runesoerensen
requested changes
Apr 6, 2026
Comment on lines
+284
to
+291
| // Special cases: development releases that don't have their | ||
| // own schedule entries. v0.10 also covers v0.9.x, and | ||
| // v0.12 also covers v0.11.x. | ||
| match minor { | ||
| 10 => version.minor() == 9, | ||
| 12 => version.minor() == 11, | ||
| _ => false, | ||
| } |
Contributor
There was a problem hiding this comment.
What is the point of this mapping? Why are we matching v0.9 and v0.11 artifacts to other releases?
It doesn't seem like there's any real value in resolving inacurate release data, presumably to show warnings for unstable/development releases that reached end of life over a decade ago (and that, as far as I can tell, no-one are actually using based on Honeycomb data)?
Replace local `src/utils/vrs.rs` module with shared types from the `nodejs-data` crate. Renames `Requirement` to `Range` throughout and re-exports `NodejsArtifact`/`NodejsInventory` from the shared crate. Removes the `DefaultNodeRequirement` wrapper since `Range` now captures the original string in its Display impl.
…mStr for NodejsReleaseLine Switch libcnb/libherokubuildpack deps from the add-release-schedule-module branch back to published =0.30.3 crates. Implement release schedule types directly in nodejs-data instead of depending on upstream schedule module. Add FromStr impl for NodejsReleaseLine and fix test compilation errors.
…tory Adapt xtask to use BTreeMap-based NodejsReleaseSchedule, remove toml_edit dependency for inline table formatting, fix sha2 version mismatch, and regenerate inventory with the new [schedule.vN] table format.
09b78f2 to
bdcf6f2
Compare
0aac35d to
b40843b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[releases]]format from libherokubuildpack'sScheduletyperequirement(e.g.,v24),end_of_life(native TOML date), and inlinemetadata(start, lts, maintenance dates)from_inventoryfalls back to old format for migrationStacked on #1328
Test plan
cargo clippy --all-targets -- --deny warningspassescargo testpasses[[releases]]with inline metadata tables, descending order)W-21451605