Skip to content

Fix tests for default preferred units #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hgrecco merged 3 commits into from
Dec 3, 2023
Merged

Fix tests for default preferred units #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b717730
TST: fix ureg attribute default_preferred_units and set autoconvert_t…
Oct 27, 2023
09e1147
TST: Use class ureg so both regular and _DEFAULT_REGISTRY are tested
Oct 27, 2023
2221718
CNF: Add mip install to github ci run to test to_preferred
Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- python-version: 3.9
numpy: "numpy"
uncertainties: "uncertainties"
extras: "sparse xarray netCDF4 dask[complete]==2023.4.0 graphviz babel==2.8"
extras: "sparse xarray netCDF4 dask[complete]==2023.4.0 graphviz babel==2.8 mip>=1.13"
runs-on: ubuntu-latest

env:
Expand Down
17 changes: 9 additions & 8 deletions pint/testsuite/test_quantity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ def test_convert(self):

@helpers.requires_mip
def test_to_preferred(self):
ureg = UnitRegistry()
Q_ = ureg.Quantity
ureg = self.ureg
Q_ = self.Q_

ureg.define("pound_force_per_square_foot = 47.8803 pascals = psf")
ureg.define("pound_mass = 0.45359237 kg = lbm")
Expand Down Expand Up @@ -409,9 +409,9 @@ def test_to_preferred(self):

@helpers.requires_mip
def test_to_preferred_registry(self):
ureg = UnitRegistry()
Q_ = ureg.Quantity
ureg.preferred_units = [
ureg = self.ureg
Q_ = self.Q_
ureg.default_preferred_units = [
ureg.m, # distance L
ureg.kg, # mass M
ureg.s, # duration T
Expand All @@ -424,9 +424,10 @@ def test_to_preferred_registry(self):

@helpers.requires_mip
def test_autoconvert_to_preferred(self):
ureg = UnitRegistry()
Q_ = ureg.Quantity
ureg.preferred_units = [
ureg = self.ureg
Q_ = self.Q_
ureg.autoconvert_to_preferred = True
ureg.default_preferred_units = [
ureg.m, # distance L
ureg.kg, # mass M
ureg.s, # duration T
Expand Down