Updated definition of US survey units to reflect the 2022 revision by NIST/NGS#1920
Updated definition of US survey units to reflect the 2022 revision by NIST/NGS#1920jacob-indigo wants to merge 6 commits intohgrecco:masterfrom
Conversation
dalito
left a comment
dalito
left a comment
There was a problem hiding this comment.
Looks fine. Data and source are correct.
Many will look at the diff of this unit definitions file. So you could make it a bit easier to review the changes (see comments).
| rod = 16.5 * foot = rd = pole = perch | ||
|
|
||
| square_rod = rod ** 2 = sq_rd = sq_rod = sq_pole = sq_perch | ||
| acre = 43560 * square_foot |
There was a problem hiding this comment.
You could leave it as is was to minimize diffs. acre = 10 * chain ** 2
There was a problem hiding this comment.
I did this to be consistent with this statement across all of the units here
but we've followed the NIST's lead here and defined all of the units directly based on "common" units (feet and miles)
|
According to NIST HB 44-2024, the original citation is Federal Register (85 FR 62698, Oct. 5, 2020) pp. 62698-62708. Despite the deprecation, the old units are still available for working with historical data, prefixed by the letter "s" - i.e., sft and smi (which are already in pint), but also sli, srd, sch, sfur, and sac for link, rod, chain, furlong and acre, respectively. So, it might be appropriate to still have those definitions in USCSLengthSurvey, and put the new survey measures into USCSLengthInternational? Then the deprecation notice can go into USCSLengthSurvey? https://www.govinfo.gov/content/pkg/FR-2020-10-05/pdf/2020-21902.pdf |
|
@jacob-indigo what do you think about @dbhart proposal? |
jacob-indigo
force-pushed
the
update_usgs_survey_length
branch
from
c1f76e3 to
e56fead
Compare
…its under USCSLengthSurvey
|
@dgoeries @andrewgsavage @maurosilber Is this something you could help me get reviewed? |
There was a problem hiding this comment.
Looks good to me in general (but it has conflicts to resolve).
@jacob-indigo - I don't have any special role here to push this further.
4 participants
Addresses issue #1912.
This is my first time contributing to Pint so I wasn't sure what your deprecation and versioning practices are. I added a placeholder in
CHANGESfor now but let me know what version you'd include this in (given that it's technically a breaking change) and how/if some notice should be given ahead of time (e.g.warn("The definition of acre will change in version 0.x to conform the 2022 revision by NIST")or whatever).pre-commit run --all-fileswith no errors