Adding GitHub content protection rule to CI#2052
Open
john-science wants to merge 1 commit intohgrecco:masterfrom
Open
Adding GitHub content protection rule to CI#2052john-science wants to merge 1 commit intohgrecco:masterfrom
john-science wants to merge 1 commit intohgrecco:masterfrom
Conversation
Contributor
Author
Sure! As it happens, I can tell that is not being done for this repo, so I am just trying to help. There is a GitHub Workflow for this repo ( So, either approach works. But either way you need a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the change?
I have constrained the permissions of the GitHub Actions in this repo.
The permissions I set are maximally constrained so that a bad actor can't use a PR into your repo to do various things like: commit to your main branch, modify a GH "Discussion" in your repo, or author an official release.
A Little Background
GitHub added this security feature in 2021.
This is not a complete solution in itself, of course. But it pairs really well with the setting pint has where Pint team members have to "approve a workflow" from a non-team member, to run CI:
For a shorter discussion of the topic than the full GitHub docs, see this blog post.
The Checklist
pre-commit run --all-fileswith no errors