Skip to content

Fix return type of PlainQuantity.to #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewgsavage merged 4 commits into from
Dec 15, 2024
Merged

Fix return type of PlainQuantity.to #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f805c31
Fix return type of PlainQuantity.to
Dec 12, 2024
a1afed3
Update changelog
Dec 12, 2024
a044a33
Update quantity.py
andrewgsavage Dec 15, 2024
67a7ec6
Merge branch 'master' into fix-return-type-of-to
andrewgsavage Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Pint Changelog

- Add docs to the functions in ``pint.testing`` (PR #2070)
- Fix round function returning float instead of int (#2081)
- Fix return type of `PlainQuantity.to` (#2088)
- Update constants to CODATA 2022 recommended values. (#2049)
- Fixed issue with `.to_compact` and Magnitudes with uncertainties / Quantities with units (PR #2069, issue #2044)

Expand Down
3 changes: 2 additions & 1 deletion pint/facets/plain/quantity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
is_duck_array_type,
is_upcast_type,
np,
Self,
zero_or_nan,
)
from ...errors import DimensionalityError, OffsetUnitCalculusError, PintTypeError
Expand Down Expand Up @@ -515,7 +516,7 @@ def ito(

def to(
self, other: QuantityOrUnitLike | None = None, *contexts, **ctx_kwargs
) -> PlainQuantity:
) -> Self:
"""Return PlainQuantity rescaled to different units.

Parameters
Expand Down