BlockNodeConnectionManagerTest flaky unit test #23384
Description
Background
org.mockito.exceptions.verification.NoInteractionsWanted: |
-- | --
No interactions wanted here: |
-> at com.hedera.node.app@0.71.0-SNAPSHOT/com.hedera.node.app.blocks.impl.streaming.BlockNodeConnectionManagerTest.testStartup(BlockNodeConnectionManagerTest.java:479) |
But found these interactions on mock 'blockStreamMetrics': |
-> at com.hedera.node.app@0.71.0-SNAPSHOT/com.hedera.node.app.blocks.impl.streaming.BlockNodeConnectionManager$BlockNodeConnectionTask.run(BlockNodeConnectionManager.java:1020) |
Actually, above is the only interaction with this mock. |
</div>
Acceptance Criteria
- Investigate and refactor unit test to remove flakiness
Dependencies
No response
Definition of Ready (DoR) Checklist
- Clear acceptance criteria
- Clear and detailed description
- Dependencies identified
- Links to documentation
- Should be completable in 2-3 Days
- Initial draft of Low-level design document
- At least high level test plan
- Groomed/Estimated
Definition of Done (DoD) Checklist
- Acceptance Criteria complete
- No Codacy issues greater than minor (in new code)
- JavaDocs updated/created
- Code commented
- Unit tests created/updated
- 80% test code coverage (in new code)
- Happy Path and major negative cases in HAPI tests as applicable