chore: RecordCreationSuite rework assertions#23168
Open
derektriley wants to merge 4 commits intomainfrom
Open
Conversation
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23168 +/- ##
=========================================
Coverage 75.91% 75.91%
Complexity 23589 23589
=========================================
Files 2556 2556
Lines 94632 94632
Branches 10093 10093
=========================================
Hits 71836 71836
Misses 19122 19122
Partials 3674 3674 🚀 New features to boost your workflow:
|
…reatesuite-rework
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Grigorov-Georgi
approved these changes
Feb 2, 2026
petreze
previously approved these changes
Feb 2, 2026
petreze
reviewed
Feb 2, 2026
Contributor
petreze
left a comment
There was a problem hiding this comment.
It seems it failed in PR check, just saw that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request refactors the
RecordCreationSuitetests to simplify and improve the validation of transfer lists in transaction records. It removes balance snapshot assertions and replaces them with direct checks on the contents of theTransferListwithin transaction records. Additionally, it increases the retry limit for transaction record queries to improve test reliability.Test refactoring and simplification:
RecordCreationSuite, reducing test flakiness and focusing validation on transaction record contents.TransferListcontents usingincludingandincludingDeductionmatchers, ensuring that the correct fee splits and deductions are present in the transaction record.Test reliability improvement:
HapiGetTxnRecordfrom 200 to 300, allowing up to 3 seconds for record retrieval and improving test stability.Imports and cleanup:
RecordCreationSuite.Related issue(s):
Fixes #23165
Notes for reviewer:
Checklist