Skip to content

fix: Add helpers and HAPI tests for code delegations with type 4 transactions#23269

Open
stoyanov-st wants to merge 3 commits intofeature/hedera-evm-pectra-supportfrom
7702-hapi-tests-for-type-4
Open

fix: Add helpers and HAPI tests for code delegations with type 4 transactions#23269
stoyanov-st wants to merge 3 commits intofeature/hedera-evm-pectra-supportfrom
7702-hapi-tests-for-type-4

Conversation

@stoyanov-st
Copy link
Contributor

Description:

Includes helper methods and HAPI tests including type 4 ethereum transactions

Related issue(s):

Fixes #23047

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
@stoyanov-st stoyanov-st added this to the v0.72 milestone Feb 3, 2026
@stoyanov-st stoyanov-st self-assigned this Feb 3, 2026
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners February 3, 2026 13:21
@stoyanov-st stoyanov-st added the EVM Protocol Engineering EVM Protocol Engineering label Feb 3, 2026
@lfdt-bot
Copy link

lfdt-bot commented Feb 3, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Feb 3, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 602dc3f1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (602dc3f) Report Missing Report Missing Report Missing
Head commit (d7e931a) 94073 75414 80.17%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23269) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@                         Coverage Diff                          @@
##             feature/hedera-evm-pectra-support   #23269   +/-   ##
====================================================================
  Coverage                                     ?   76.22%           
  Complexity                                   ?    23591           
====================================================================
  Files                                        ?     2537           
  Lines                                        ?    94258           
  Branches                                     ?    10059           
====================================================================
  Hits                                         ?    71848           
  Misses                                       ?    18745           
  Partials                                     ?     3665           
Files with missing lines Coverage Δ Complexity Δ
.../impl/exec/delegation/CodeDelegationProcessor.java 80.00% <100.00%> (ø) 19.00 <0.00> (?)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lukasz Gasior <lukasz.gasior@swirldslabs.com>
return this;
}

public HapiGetAccountInfo hasNoDelegationAddress() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing an assertion for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EVM Protocol Engineering EVM Protocol Engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants