Skip to content

feat: intake benchmark#23305

Open
lpetrovic05 wants to merge 46 commits intomainfrom
23113-intake-benchmark
Open

feat: intake benchmark#23305
lpetrovic05 wants to merge 46 commits intomainfrom
23113-intake-benchmark

Conversation

@lpetrovic05
Copy link
Contributor

@lpetrovic05 lpetrovic05 commented Feb 4, 2026

closes #23113

This PR introduces a very basic intake benchmark, a ticket has been created with potential improvements: #23312

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

# Conflicts:
#	platform-sdk/consensus-utility/src/test/java/org/hiero/consensus/RandotronTests.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/crypto/CryptoArgsProvider.java
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/gui/HashgraphGui.java
c
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 added this to the v0.72 milestone Feb 4, 2026
@lpetrovic05 lpetrovic05 self-assigned this Feb 4, 2026
@lfdt-bot
Copy link

lfdt-bot commented Feb 4, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Feb 4, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 61563df1 83.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (61563df) Report Missing Report Missing Report Missing
Head commit (1c67b48) 93202 74843 80.30%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23305) 6 5 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...va/org/hiero/consensus/event/EventGraphSource.java 66.66% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #23305   +/-   ##
=========================================
  Coverage     76.39%   76.40%           
- Complexity    23403    23407    +4     
=========================================
  Files          2501     2501           
  Lines         93380    93385    +5     
  Branches       9911     9913    +2     
=========================================
+ Hits          71342    71347    +5     
  Misses        18443    18443           
  Partials       3595     3595           
Files with missing lines Coverage Δ Complexity Δ
...hiero/consensus/pcli/graph/EventGraphPipeline.java 95.65% <ø> (ø) 10.00 <0.00> (ø)
...ensus/pcli/graph/OrphanBufferEventGraphSource.java 78.26% <ø> (ø) 8.00 <0.00> (ø)
...ero/consensus/pcli/graph/PcesEventGraphSource.java 71.42% <ø> (ø) 3.00 <0.00> (ø)
...va/org/hiero/consensus/event/EventGraphSource.java 77.77% <66.66%> (ø) 4.00 <2.00> (?)

... and 16 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
c
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
timo0
timo0 previously approved these changes Feb 5, 2026
Copy link
Member

@timo0 timo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lpetrovic05! Some minor comments

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
timo0
timo0 previously approved these changes Feb 5, 2026
Copy link
Member

@timo0 timo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor comment :)

PlatformEvent next();

/**
* Returns a list of the next {@code count} events from this source. If
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed if

mxtartaglia-sl
mxtartaglia-sl previously approved these changes Feb 5, 2026
Copy link
Contributor

@mxtartaglia-sl mxtartaglia-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'm approving

Few comments, feel free to reject, update or leave for latter.

  1. GeneratorEventGraphSource — The name is redundant. "Generator" and "Source" express the same. Maybe StandardEventGraphSource, I don't think we will use many others after this one.
  2. In production code we already have a BytesSigner, EventSigner duplicates just for test and I think could be confusing.
  3. the hardcoded 5-second timeout in EventCounter could come as a parameter

@abies
Copy link
Contributor

abies commented Feb 6, 2026

I disagree regarding redundancy in GeneratorEventGraphSource name. Another example would be FileEventGraphSource, another NetworkEventGraphSource, and possibly InteractiveUIEventGraphSource. All these are graph sources, but they are not generating events themselves.

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

# Conflicts:
#	platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/emitter/EventEmitter.java
#	platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/GeneratorConsensus.java
#	platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/GeneratorEventGraphSource.java
#	platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/GeneratorEventGraphSourceBuilder.java
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/gui/HashgraphGui.java
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/module-info.java
c
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@mxtartaglia-sl
Copy link
Contributor

Makes sense @abies , didn't see it in that way

@lpetrovic05 lpetrovic05 dismissed stale reviews from mxtartaglia-sl and timo0 via 9c03a66 February 6, 2026 12:49
@lpetrovic05
Copy link
Contributor Author

  1. GeneratorEventGraphSource — The name is redundant. "Generator" and "Source" express the same. Maybe StandardEventGraphSource, I don't think we will use many others after this one.
    Seems that the agreement is not to change
  1. In production code we already have a BytesSigner, EventSigner duplicates just for test and I think could be confusing.
    I renamed it, but essentially I need an interface like this
  1. the hardcoded 5-second timeout in EventCounter could come as a parameter
    Changed

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Copy link
Member

@timo0 timo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intake benchmark

5 participants