Conversation
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> # Conflicts: # platform-sdk/consensus-utility/src/test/java/org/hiero/consensus/RandotronTests.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/crypto/CryptoArgsProvider.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/gui/HashgraphGui.java
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #23305 +/- ##
=========================================
Coverage 76.39% 76.40%
- Complexity 23403 23407 +4
=========================================
Files 2501 2501
Lines 93380 93385 +5
Branches 9911 9913 +2
=========================================
+ Hits 71342 71347 +5
Misses 18443 18443
Partials 3595 3595
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
...ensus-event-intake-impl/src/jmh/java/org/hiero/consensus/event/intake/impl/EventCounter.java
Outdated
Show resolved
Hide resolved
timo0
left a comment
There was a problem hiding this comment.
thanks @lpetrovic05! Some minor comments
...ensus-event-intake-impl/src/jmh/java/org/hiero/consensus/event/intake/impl/EventCounter.java
Outdated
Show resolved
Hide resolved
...ensus-event-intake-impl/src/jmh/java/org/hiero/consensus/event/intake/impl/EventCounter.java
Show resolved
Hide resolved
...us-event-intake-impl/src/jmh/java/org/hiero/consensus/event/intake/impl/IntakeBenchmark.java
Outdated
Show resolved
Hide resolved
...us-event-intake-impl/src/jmh/java/org/hiero/consensus/event/intake/impl/IntakeBenchmark.java
Outdated
Show resolved
Hide resolved
...us-event-intake-impl/src/jmh/java/org/hiero/consensus/event/intake/impl/IntakeBenchmark.java
Show resolved
Hide resolved
...ava/com/swirlds/platform/test/fixtures/event/generator/GeneratorEventGraphSourceBuilder.java
Outdated
Show resolved
Hide resolved
...ava/com/swirlds/platform/test/fixtures/event/generator/GeneratorEventGraphSourceBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
| PlatformEvent next(); | ||
|
|
||
| /** | ||
| * Returns a list of the next {@code count} events from this source. If |
mxtartaglia-sl
left a comment
There was a problem hiding this comment.
Nice, I'm approving
Few comments, feel free to reject, update or leave for latter.
- GeneratorEventGraphSource — The name is redundant. "Generator" and "Source" express the same. Maybe StandardEventGraphSource, I don't think we will use many others after this one.
- In production code we already have a BytesSigner, EventSigner duplicates just for test and I think could be confusing.
- the hardcoded 5-second timeout in EventCounter could come as a parameter
|
I disagree regarding redundancy in |
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> # Conflicts: # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/emitter/EventEmitter.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/GeneratorConsensus.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/GeneratorEventGraphSource.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/GeneratorEventGraphSourceBuilder.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/gui/HashgraphGui.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/module-info.java
|
Makes sense @abies , didn't see it in that way |
9c03a66
|
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
closes #23113
This PR introduces a very basic intake benchmark, a ticket has been created with potential improvements: #23312