Open
Conversation
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
# Conflicts: # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/BlockNodeConnectionConfig.java
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #23321 +/- ##
=======================================
Coverage ? 78.02%
Complexity ? 23416
=======================================
Files ? 2458
Lines ? 91495
Branches ? 9713
=======================================
Hits ? 71392
Misses ? 16507
Partials ? 3596
🚀 New features to boost your workflow:
|
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR handles the possibility of multiple
BehindPublisherresponses returned from BNs. We should allow receiving at most 1 such responses and if we receive a 2nd one, we should end the stream with codeRESETand reschedule the connection after a configurable period of time (behindPublisherScheduleDelay- default 30 seconds). ThemaxBehindPublishersAllowedis also a configurable property, defaulted to1Related issue(s):
Fixes #23250
Notes for reviewer:
Checklist