Skip to content

fix: Fix Consensus, File, and Token Service Tests when Simple Fees is enabled#23363

Open
joshmarinacci wants to merge 23 commits intomainfrom
simplefees-consensus-tests-fixes
Open

fix: Fix Consensus, File, and Token Service Tests when Simple Fees is enabled#23363
joshmarinacci wants to merge 23 commits intomainfrom
simplefees-consensus-tests-fixes

Conversation

@joshmarinacci
Copy link
Contributor

@joshmarinacci joshmarinacci commented Feb 5, 2026

Description:

Fixes the Consensus, File, and Token service fee tests when Simple Fees is enabled. Since the price varies between old and new fees, now these tests will use the appropriate value depending on whether Simple Fees is enabled or not. Also fixes TopicCreate suite.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci requested a review from a team as a code owner February 5, 2026 17:14
@trunk-io
Copy link

trunk-io bot commented Feb 5, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@joshmarinacci joshmarinacci self-assigned this Feb 5, 2026
@joshmarinacci joshmarinacci added this to the v0.72 milestone Feb 5, 2026
@lfdt-bot
Copy link

lfdt-bot commented Feb 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@joshmarinacci joshmarinacci changed the title Fix Consensus Tests when Simple Fees is enabled fix: Fix Consensus Tests when Simple Fees is enabled Feb 5, 2026
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix unit tests when enabling simple fees

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci requested a review from a team as a code owner February 5, 2026 19:07
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci changed the title fix: Fix Consensus Tests when Simple Fees is enabled fix: Fix Consensus and File Service Tests when Simple Fees is enabled Feb 5, 2026
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
aderevets
aderevets previously approved these changes Feb 5, 2026
mhess-swl
mhess-swl previously approved these changes Feb 6, 2026
Copy link
Contributor

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…/suites/hip1261/utils/SimpleFeesScheduleConstantsInUsd.java

Co-authored-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Josh Marinacci <276938+joshmarinacci@users.noreply.github.com>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@codacy-production
Copy link

codacy-production bot commented Feb 6, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (78bb154) 93190 74841 80.31%
Head commit (8d5778e) 93196 (+6) 74841 (+0) 80.30% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23363) 7 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/src/main/java/org/hiero/hapi/fees/FeeResult.java 0.00% 7 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #23363      +/-   ##
============================================
- Coverage     76.40%   76.40%   -0.01%     
- Complexity    23405    23406       +1     
============================================
  Files          2501     2501              
  Lines         93373    93379       +6     
  Branches       9912     9912              
============================================
  Hits          71344    71344              
- Misses        18433    18439       +6     
  Partials       3596     3596              
Files with missing lines Coverage Δ Complexity Δ
...n/java/com/hedera/node/config/data/FeesConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...s/src/main/java/org/hiero/hapi/fees/FeeResult.java 81.03% <0.00%> (-9.36%) 14.00 <0.00> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshmarinacci and others added 7 commits February 6, 2026 04:41
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix TopicCustomFeeSubmitMessageTest
add new variant with the allowed diff parameters

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci changed the title fix: Fix Consensus and File Service Tests when Simple Fees is enabled fix: Fix Consensus, File, and Token Service Tests when Simple Fees is enabled Feb 6, 2026
fix token services tests

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci requested review from Neeharika-Sompalli and removed request for Neeharika-Sompalli February 6, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants