fix: Fix Consensus, File, and Token Service Tests when Simple Fees is enabled#23363
Open
joshmarinacci wants to merge 23 commits intomainfrom
Open
fix: Fix Consensus, File, and Token Service Tests when Simple Fees is enabled#23363joshmarinacci wants to merge 23 commits intomainfrom
joshmarinacci wants to merge 23 commits intomainfrom
Conversation
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
fix unit tests when enabling simple fees Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
aderevets
previously approved these changes
Feb 5, 2026
mhess-swl
previously approved these changes
Feb 6, 2026
...main/java/com/hedera/services/bdd/suites/hip1261/utils/SimpleFeesScheduleConstantsInUsd.java
Outdated
Show resolved
Hide resolved
…/suites/hip1261/utils/SimpleFeesScheduleConstantsInUsd.java Co-authored-by: Matt Hess <matt.hess@swirldslabs.com> Signed-off-by: Josh Marinacci <276938+joshmarinacci@users.noreply.github.com>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #23363 +/- ##
============================================
- Coverage 76.40% 76.40% -0.01%
- Complexity 23405 23406 +1
============================================
Files 2501 2501
Lines 93373 93379 +6
Branches 9912 9912
============================================
Hits 71344 71344
- Misses 18433 18439 +6
Partials 3596 3596
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
...main/java/com/hedera/services/bdd/suites/hip1261/utils/SimpleFeesScheduleConstantsInUsd.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
…' into simplefees-consensus-tests-fixes
fix TopicCustomFeeSubmitMessageTest add new variant with the allowed diff parameters Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
fix token services tests Signed-off-by: Josh Marinacci <joshua@marinacci.org>
aderevets
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the Consensus, File, and Token service fee tests when Simple Fees is enabled. Since the price varies between old and new fees, now these tests will use the appropriate value depending on whether Simple Fees is enabled or not. Also fixes TopicCreate suite.
Checklist