chore: Move consensus-state classes in separate module#23379
Open
chore: Move consensus-state classes in separate module#23379
Conversation
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
# Conflicts: # platform-sdk/consensus-state/src/main/java/org/hiero/consensus/state/signed/SignedState.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/StateInitializer.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/reconnect/ReconnectStatePeerProtocol.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/snapshot/SignedStateFileReader.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/snapshot/SignedStateFileWriter.java # platform-sdk/swirlds-platform-core/src/main/java/module-info.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/SignedStateFileReadWriteTest.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/eventhandling/TransactionPrehandlerTests.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/signed/DefaultStateHasherTests.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/system/state/notifications/StateHashedNotificationTest.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/wiring/SignedStateReserverTest.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/state/SignedStateUtils.java
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
# Conflicts: # platform-sdk/swirlds-cli/src/main/java/org/hiero/consensus/pcli/recovery/EventRecoveryWorkflow.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gui/internal/GuiStateInfo.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/module-info.java
poulok
approved these changes
Feb 6, 2026
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #23379 +/- ##
============================================
- Coverage 78.02% 78.01% -0.02%
+ Complexity 23413 23407 -6
============================================
Files 2458 2459 +1
Lines 91459 91462 +3
Branches 9710 9710
============================================
- Hits 71359 71352 -7
- Misses 16511 16518 +7
- Partials 3589 3592 +3
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves the minimal set of state classes that are used by our modules into a new module
consensus-state. We will have to move more classes later, but for the gossip, pces, and reconnect module, this is all we need.Related issue(s):
Fixes #23311