ci(workflow): update trigger release to use github create workflow#23380
ci(workflow): update trigger release to use github create workflow#23380andrewb1269 wants to merge 21 commits intomainfrom
Conversation
**Description**: Update the future official trigger release workflow to use the Github create release callable workflow. **Related Issue(s)**: Implements #23368 Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR updates the trigger release workflow to use a callable workflow (zxc-create-github-release.yaml) for creating GitHub releases, replacing inline release creation steps. However, the implementation contains several critical logic errors that would prevent releases from being created correctly.
Changes:
- Renamed job from
create-new-releasetocreate-new-tagand added version output - Removed inline GitHub release creation steps (release notes generation and publishing)
- Added new
create-github-releasejob that calls thezxc-create-github-release.yamlworkflow - Changed default value of
dry-runparameter in callable workflow fromfalsetotrue - Changed permissions from
contents: readtocontents: write
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/zxc-create-github-release.yaml |
Changed default value of dry-run parameter from false to true, which breaks existing callers |
.github/workflows/flow-trigger-release.yaml |
Renamed job, removed inline release steps, added callable workflow job with incorrect parameter logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23380 +/- ##
=========================================
Coverage 76.40% 76.40%
Complexity 23406 23406
=========================================
Files 2501 2501
Lines 93379 93379
Branches 9911 9911
=========================================
Hits 71345 71345
Misses 18442 18442
Partials 3592 3592 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Description:
Update the future official trigger release workflow to use the Github create release callable workflow.
Related Issue(s):
Implements #23368
Testing:
Example workflow run here showing the parameters are passed into the callable workflow correctly: