Skip to content

ci(workflow): update trigger release to use github create workflow#23380

Open
andrewb1269 wants to merge 21 commits intomainfrom
23368-replace-the-create-github-releases-step-in-the-trigger-release-workflow
Open

ci(workflow): update trigger release to use github create workflow#23380
andrewb1269 wants to merge 21 commits intomainfrom
23368-replace-the-create-github-releases-step-in-the-trigger-release-workflow

Conversation

@andrewb1269
Copy link
Contributor

@andrewb1269 andrewb1269 commented Feb 6, 2026

Description:

Update the future official trigger release workflow to use the Github create release callable workflow.

Related Issue(s):

Implements #23368

Testing:

Example workflow run here showing the parameters are passed into the callable workflow correctly:

Input Parameters:
  Release Version: build-00279
  Create Release Notes: true
  Create Release: true
  Dry Run: true

**Description**:

Update the future official trigger release workflow to use the Github create release callable workflow.

**Related Issue(s)**:

Implements #23368

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
@andrewb1269 andrewb1269 self-assigned this Feb 6, 2026
@andrewb1269 andrewb1269 requested a review from a team as a code owner February 6, 2026 15:03
@andrewb1269 andrewb1269 added the github_actions Pull requests that update Github Actions code. label Feb 6, 2026
@trunk-io
Copy link

trunk-io bot commented Feb 6, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Feb 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the trigger release workflow to use a callable workflow (zxc-create-github-release.yaml) for creating GitHub releases, replacing inline release creation steps. However, the implementation contains several critical logic errors that would prevent releases from being created correctly.

Changes:

  • Renamed job from create-new-release to create-new-tag and added version output
  • Removed inline GitHub release creation steps (release notes generation and publishing)
  • Added new create-github-release job that calls the zxc-create-github-release.yaml workflow
  • Changed default value of dry-run parameter in callable workflow from false to true
  • Changed permissions from contents: read to contents: write

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
.github/workflows/zxc-create-github-release.yaml Changed default value of dry-run parameter from false to true, which breaks existing callers
.github/workflows/flow-trigger-release.yaml Renamed job, removed inline release steps, added callable workflow job with incorrect parameter logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #23380   +/-   ##
=========================================
  Coverage     76.40%   76.40%           
  Complexity    23406    23406           
=========================================
  Files          2501     2501           
  Lines         93379    93379           
  Branches       9911     9911           
=========================================
  Hits          71345    71345           
  Misses        18442    18442           
  Partials       3592     3592           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Feb 6, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (968e9bc) 93196 74838 80.30%
Head commit (cf89161) 93196 (+0) 74838 (+0) 80.30% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23380) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
rbarker-dev
rbarker-dev previously approved these changes Feb 6, 2026
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github Actions code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the create github releases step in the trigger release workflow

3 participants