refactor: Remove transitive dependency from swirlds-platform-core on consensus-hashgraph-impl#23389
Open
refactor: Remove transitive dependency from swirlds-platform-core on consensus-hashgraph-impl#23389
swirlds-platform-core on consensus-hashgraph-impl#23389Conversation
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-platform-core/src/testFixtures/java/module-info.java
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/consensus-hashgraph-impl/src/test/java/org/hiero/consensus/hashgraph/impl/HashgraphGuiMain.java # platform-sdk/consensus-hashgraph-impl/src/test/java/org/hiero/consensus/hashgraph/impl/consensus/AncientParentsTest.java # platform-sdk/consensus-hashgraph-impl/src/test/java/org/hiero/consensus/hashgraph/impl/consensus/ConsensusEngineContractTest.java # platform-sdk/consensus-hashgraph-impl/src/test/java/org/hiero/consensus/hashgraph/impl/consensus/ConsensusTestDefinitions.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/module-info.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/consensus/ConsensusTestOrchestrator.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/consensus/framework/ConsensusTestNode.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/consensus/framework/OrchestratorBuilder.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/event/generator/StandardGraphGenerator.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/org/hiero/consensus/hashgraph/impl/test/fixtures/gui/runner/TestGuiSource.java # platform-sdk/swirlds-cli/src/main/java/org/hiero/consensus/pcli/GenesisPlatformStateCommand.java # platform-sdk/swirlds-cli/src/main/java/org/hiero/consensus/pcli/recovery/EventRecoveryWorkflow.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/module-info.java
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
…tive-test-fixtures
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
swirlds-platform-core on consensus-hashgraph-impl
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/consensus-hashgraph-impl/src/test/java/org/hiero/consensus/hashgraph/impl/consensus/AncientParentsTest.java # platform-sdk/consensus-hashgraph-impl/src/test/java/org/hiero/consensus/hashgraph/impl/consensus/ConsensusEngineContractTest.java # platform-sdk/consensus-hashgraph-impl/src/testFixtures/java/module-info.java # platform-sdk/swirlds-platform-core/build.gradle.kts # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/graph/SimpleGraph.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/module-info.java
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23389 +/- ##
=========================================
Coverage 78.02% 78.02%
+ Complexity 23413 23412 -1
=========================================
Files 2458 2458
Lines 91459 91459
Branches 9710 9710
=========================================
+ Hits 71359 71364 +5
+ Misses 16511 16507 -4
+ Partials 3589 3588 -1 see 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR eliminates the transitive dependency from
swirlds-platform-coretestFixtures onconsensus-hashgraph-impltestFixture. The concern with this dependency is that classes likeEventImplcould be leaked to a src/test module via the testFixtures.SimpleGraph was split into two classes that implement a new interface, each parameterizing it with the type of event they provide. The one that provides
PlatformEventis exposed externally for other testFixtures and tests. The one that providesEventImplis only exposed to theconsensus-hashgraph-implsrc and test module, not to any external modules. This ensures that classes such asEventImplare not exposed outside of the module at all.Related issue(s):
Fixes #23091