Skip to content

fix: Fix flaky SequentialTaskSchedulerTests.squelching() test#23406

Merged
poulok merged 1 commit intomainfrom
23405-fix-flaky-test
Feb 6, 2026
Merged

fix: Fix flaky SequentialTaskSchedulerTests.squelching() test#23406
poulok merged 1 commit intomainfrom
23405-fix-flaky-test

Conversation

@poulok
Copy link
Contributor

@poulok poulok commented Feb 6, 2026

Fixes #23405

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
@poulok poulok added this to the v0.72 milestone Feb 6, 2026
@poulok poulok self-assigned this Feb 6, 2026
@poulok poulok requested a review from a team as a code owner February 6, 2026 21:20
@poulok poulok requested a review from abies February 6, 2026 21:20
@trunk-io
Copy link

trunk-io bot commented Feb 6, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Feb 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@poulok poulok requested review from mxtartaglia-sl and removed request for abies February 6, 2026 21:24
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (63f96a2) 91263 74843 82.01%
Head commit (31dc807) 91263 (+0) 74842 (-1) 82.01% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23406) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #23406      +/-   ##
============================================
- Coverage     78.02%   78.02%   -0.01%     
+ Complexity    23403    23402       -1     
============================================
  Files          2458     2458              
  Lines         91446    91446              
  Branches       9707     9707              
============================================
- Hits          71351    71348       -3     
- Misses        16503    16504       +1     
- Partials       3592     3594       +2     

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poulok poulok merged commit 0ee3021 into main Feb 6, 2026
82 checks passed
@poulok poulok deleted the 23405-fix-flaky-test branch February 6, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky Test: SequentialTaskSchedulerTests.squelching()

3 participants