feat: search next available tcp port for port forward function call by JeffreyDallas · Pull Request #2362 · hiero-ledger/solo

JeffreyDallas · 2025-07-28T06:04:02Z

Description

This pull request changes the following:

update component scheme to save port forward information
refactor portForward function to support using next available port number or re-use pre-existing port number
refactor addNewComponent function to support replace pre-existing component
search next available tcp port for port forward function call
a utility function managePortForward to check pre-exising port number used for port forward, if not exist then use next available TCP port

Related Issues

Pull request (PR) checklist

This PR added tests (unit, integration, and/or end-to-end)
This PR updated documentation
This PR added no TODOs or commented out code
This PR has no breaking changes
Any technical debt has been documented as a separate issue and linked to this PR
Any package.json changes have been explained to and approved by a repository manager
All related issues have been linked to this PR
All changes in this PR are included in the description
When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

This PR added unit tests
This PR added integration/end-to-end tests
These changes required manual testing that is documented below
Anything not tested is documented

The following manual testing was done:

TBD

The following was not tested:

TBD

Commit message guidelines

We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:

BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
The title is prefixed with one of the following:

Prefix	Description	Semantic Version Update	Captured in Release Notes
feat:	a new feature	MINOR	Yes
fix:	a bug fix	PATCH	Yes
perf:	performance	PATCH	Yes
refactor:	code change that isn't feature or fix	none	No
test:	adding missing tests	none	No
docs:	changes to documentation	none	Yes
build:	changes to build process	none	No
ci:	changes to CI configuration	none	No
style:	formatting, missing semi-colons, etc	none	No
chore:	updating grunt tasks etc; no production code change	none	No

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

github-actions · 2025-07-28T06:12:56Z

Unit Test Results - Linux

32 tests ±0 32 ✅ ±0 0s ⏱️ ±0s
16 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit eadad52. ± Comparison against base commit 8d8292f.

♻️ This comment has been updated with latest results.

github-actions · 2025-07-28T06:13:39Z

Unit Test Results - Windows

1 files ±0 177 suites +2 4s ⏱️ -1s
494 tests +2 494 ✅ +2 0 💤 ±0 0 ❌ ±0
498 runs +2 498 ✅ +2 0 💤 ±0 0 ❌ ±0

Results for commit eadad52. ± Comparison against base commit 8d8292f.

♻️ This comment has been updated with latest results.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

… into 02300-D-tcp-port

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

github-actions · 2025-07-28T07:44:14Z

E2E Test Report

20 files 139 suites 2h 5m 51s ⏱️
379 tests 379 ✅ 0 💤 0 ❌
392 runs 392 ✅ 0 💤 0 ❌

Results for commit 6d07e40.

github-actions · 2025-07-28T07:44:14Z

E2E Test Report

20 files ±0 139 suites ±0 2h 9m 12s ⏱️ + 1m 9s
379 tests ±0 379 ✅ ±0 0 💤 ±0 0 ❌ ±0
392 runs ±0 392 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit eadad52. ± Comparison against base commit 8d8292f.

♻️ This comment has been updated with latest results.

codacy-production · 2025-07-28T07:44:37Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.09% (target: -1.00%)	✅ 78.25%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`8d8292f`)	41562	35728	85.96%
Head commit (`eadad52`)	41958 (+396)	36029 (+301)	85.87% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#2362)	469	367	78.25%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

jeromy-cannon

all of the instances of

solo/src/core/logging/solo-logger.ts

Line 28 in e12938f

addMessageGroupMessage(key: string, message: string): void;

where it is adding a port message needs to be updated to use the port that was incremented from the default

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

…tcp-port Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/integration/kube/k8-client/resources/pod/k8-client-pod.ts

Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

… into 02300-D-tcp-port

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

…tcp-port Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # package.json

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

## [0.43.0](v0.42.0...v0.43.0) (2025-08-15) ### Features * Add kubectl dependency manager ([#2422](#2422)) ([a482302](a482302)) * control block node version as environment variable ([#2472](#2472)) ([c678d90](c678d90)) * Docker build section ([#2433](#2433)) ([2578351](2578351)) * search next available tcp port for port forward function call ([#2362](#2362)) ([22f5a04](22f5a04)) ### Bug Fixes * disable the setting of the gRPC web endpoint when running for apps that are not CN, bump MN to v0.136.0 ([#2463](#2463)) ([16b7cb2](16b7cb2)) * Migrate to using @hiero-ledger/sdk ([#2452](#2452)) ([b9a7018](b9a7018)) * Remove requirement for kind dependency ([#2451](#2451)) ([974303c](974303c)) * update markdown documentation generation script ([#2449](#2449)) ([328544a](328544a))

swirlds-automation · 2025-08-15T19:44:12Z

🎉 This PR is included in version 0.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-09-09T16:55:04Z

🎉 This PR is included in version 0.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas added 2 commits July 28, 2025 00:31

save

0b649fc

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

save

90348e9

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested a review from a team as a code owner July 28, 2025 06:04

JeffreyDallas requested review from jeromy-cannon and nathanklick July 28, 2025 06:04

JeffreyDallas self-assigned this Jul 28, 2025

JeffreyDallas requested a review from Copilot July 28, 2025 06:04

This comment was marked as outdated.

Sign in to view

save

c2b4f53

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested a review from Copilot July 28, 2025 06:10

This comment was marked as outdated.

Sign in to view

JeffreyDallas and others added 4 commits July 28, 2025 01:15

Update src/core/network/port-utilities.ts

e45cf4a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Update src/integration/kube/k8-client/resources/pod/k8-client-pod.ts

13f106c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

add delay

9222359

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Merge branch '02300-D-tcp-port' of https://github.com/hiero-ledger/solo…

47f95a6

… into 02300-D-tcp-port

JeffreyDallas requested a review from Copilot July 28, 2025 06:20

This comment was marked as outdated.

Sign in to view

JeffreyDallas and others added 3 commits July 28, 2025 01:23

Update src/integration/kube/k8-client/resources/pod/k8-client-pod.ts

43f559d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Update src/core/network/port-utilities.ts

c29c721

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Update src/core/network/port-utilities.ts

6d07e40

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

jeromy-cannon requested changes Jul 28, 2025

View reviewed changes

jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Jul 28, 2025

JeffreyDallas added 2 commits July 28, 2025 12:28

save

1abca60

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Merge commit 'e12938ffd0d09302beaf28a5ec1f7cf964145afa' into 02300-D-…

1d26487

…tcp-port Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/integration/kube/k8-client/resources/pod/k8-client-pod.ts

JeffreyDallas removed the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Jul 28, 2025

jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Aug 8, 2025

JeffreyDallas and others added 2 commits August 8, 2025 15:24

Update src/integration/kube/k8-client/resources/pod/k8-client-pod.ts

d115a13

Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Update src/integration/kube/k8-client/resources/pod/k8-client-pod.ts

679183b

Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Aug 8, 2025

JeffreyDallas added 4 commits August 8, 2025 18:16

add migrationv2

63da2ec

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Merge branch '02300-D-tcp-port' of https://github.com/hiero-ledger/solo…

1214642

… into 02300-D-tcp-port

move portforward check function

cad9b34

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

test migration

b7c1019

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested a review from a team as a code owner August 11, 2025 13:04

JeffreyDallas and others added 5 commits August 11, 2025 13:29

save

2ba30ee

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Merge commit '89910ccb2b86db143248b3965e8a14b4eca3fd31' into 02300-D-…

c65a33d

…tcp-port Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # package.json

save

e79aecd

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

fix unit test

177514e

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Merge branch 'main' into 02300-D-tcp-port

c7e3b99

JeffreyDallas requested a review from jeromy-cannon August 12, 2025 16:22

JeffreyDallas added 2 commits August 12, 2025 11:31

update

ca5328c

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

fix check

eadad52

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

jeromy-cannon approved these changes Aug 12, 2025

View reviewed changes

jeromy-cannon added PR: Ready to Merge A pull request that is ready to merge. and removed PR: Needs Team Approval A pull request that needs review from a team member. labels Aug 12, 2025

JeffreyDallas merged commit 22f5a04 into main Aug 12, 2025
44 of 45 checks passed

JeffreyDallas deleted the 02300-D-tcp-port branch August 12, 2025 21:10

swirlds-automation added the released label Aug 15, 2025

swirlds-automation added the released on @0.43.x label Sep 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: search next available tcp port for port forward function call#2362

feat: search next available tcp port for port forward function call#2362
JeffreyDallas merged 58 commits intomainfrom
02300-D-tcp-port

JeffreyDallas commented Jul 28, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

codacy-production bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

jeromy-cannon left a comment

Uh oh!

Uh oh!

swirlds-automation commented Aug 15, 2025

Uh oh!

swirlds-automation commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

JeffreyDallas commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Pull request (PR) checklist

Testing

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Linux

Uh oh!

github-actions bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Windows

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jul 28, 2025

E2E Test Report

Uh oh!

github-actions bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Report

Uh oh!

codacy-production bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Uh oh!

jeromy-cannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swirlds-automation commented Aug 15, 2025

Uh oh!

swirlds-automation commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JeffreyDallas commented Jul 28, 2025 •

edited

Loading

github-actions bot commented Jul 28, 2025 •

edited

Loading

github-actions bot commented Jul 28, 2025 •

edited

Loading

github-actions bot commented Jul 28, 2025 •

edited

Loading

codacy-production bot commented Jul 28, 2025 •

edited

Loading