Skip to content

Upgrade higlass front end to v1.13 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzt merged 1 commit into from
Nov 12, 2024
Merged

Upgrade higlass front end to v1.13 #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/higlass/_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="https://esm.sh/higlass@{{ higlass_version }}/dist/hglib.css">
<script src="https://unpkg.com/requirejs-toggle"></script>
{% for plugin_url in plugin_urls %}
<script src="{{ plugin_url }}"></script>
Expand All @@ -24,7 +23,7 @@
<div id="{{ output_div }}"></div>
</body>
<script type="module">
import hglib from "https://esm.sh/higlass@{{ higlass_version }}?deps=react@{{ react_version }},react-dom@{{ react_version }},pixi.js@{{ pixijs_version }}";
import * as hglib from "https://esm.sh/higlass@{{ higlass_version }}?deps=react@{{ react_version }},react-dom@{{ react_version }},pixi.js@{{ pixijs_version }}";
hglib.viewer(
document.getElementById('{{ output_div }}'),
{{ viewconf }},
Expand All @@ -37,7 +36,7 @@

def viewconf_to_html(
viewconf: dict,
higlass_version: str = "1.12",
higlass_version: str = "1.13",
react_version: str = "17",
pixijs_version: str = "6",
output_div: str = "vis",
Expand Down
1 change: 0 additions & 1 deletion src/higlass/_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

class HiGlassWidget(anywidget.AnyWidget):
_esm = pathlib.Path(__file__).parent / "widget.js"
_css = "https://esm.sh/[email protected]/dist/hglib.css"

_viewconf = t.Dict(allow_none=False).tag(sync=True)
_options = t.Dict().tag(sync=True)
Expand Down
2 changes: 1 addition & 1 deletion src/higlass/widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import hglib from "https://esm.sh/higlass@1.12?deps=react@17,react-dom@17,pixi.js@6";
import * as hglib from "https://esm.sh/higlass@1.13?deps=react@17,react-dom@17,pixi.js@6";

/**
* @param {{
Expand Down