function_of_keyseq() triggers fatal error when key sequence is not defined

[bolangi]

I think this function should not require the user to parse function_dumper()
output to know which sequences are safe to query.

use v5.30;
use Term::ReadLine;
my $term = Term::ReadLine->new('keyboard code and custom dispatch test');
say $term->get_function_name(($term->function_of_keyseq("\e[A"))[0]);
my $function_object = $term->function_of_keyseq("\e");
say "got function object";
say $term->get_function_name(($term->function_of_keyseq("\e"))[0]);
say "got function name";

perl test-function-of-keyseq
previous-history
got function object
Term::ReadLine::Gnu::XS::rl_get_function_name: Expected function to be of type rl_command_func_tPtr; got Keymap=SCALAR(0x55f129e3fe38) instead at /home/jroth/.plenv/versions/5.38.0/lib/perl5/site_perl/5.38.0/x86_64-linux/Term/ReadLine/Gnu.pm line 886.

[hirooih]

You have to use the second return-value of function_of_keyseq as my sample code on #25 does.

[bolangi]

On Mon, Dec 04, 2023 at 06:41:59AM -0800, hirooih wrote: You have to use the second return-value of `function_of_keyseq` as [my sample code](#25 (comment)) on #25 does.

That's useful code, however, it still fails if the key sequence is not defined. ```perl use v5.30; use Term::ReadLine; BEGIN { import Term::ReadLine::Gnu qw(:keymap_type); } my $term = Term::ReadLine->new('keyboard code and custom dispatch test'); dump_keyseq("\eOP"); sub dump_keyseq { my $seq = shift; my ($data, $type) = $term->function_of_keyseq($seq); if ($type == ISFUNC) { say "function: ", $term->get_function_name($data); } elsif ($type == ISKMAP) { say "keymap: ", $term->get_keymap_name($data); } elsif ($type == ISMACR) { say "macro: $data"; } else { say "unknown type: $type"; } } ``` ```sh perl tk9 Use of uninitialized value in subroutine entry at /home/jroth/.plenv/versions/5.38.0/lib/perl5/site_perl/5.38.0/x86_64-linux/Term/ReadLine/Gnu.pm line 886. Term::ReadLine::Gnu::XS::rl_get_function_name: Expected function to be of type rl_command_func_tPtr; got undef instead at /home/jroth/.plenv/versions/5.38.0/lib/perl5/site_perl/5.38.0/x86_64-linux/Term/ReadLine/Gnu.pm line 886. ```

…

-- Joel Roth