Skip to content

Comments

Fix: pascal_case() formatter breaks PascalCase capitalization when adding prefix#69

Merged
hit9 merged 1 commit intohit9:masterfrom
D-Walther:master
Aug 27, 2025
Merged

Fix: pascal_case() formatter breaks PascalCase capitalization when adding prefix#69
hit9 merged 1 commit intohit9:masterfrom
D-Walther:master

Conversation

@D-Walther
Copy link
Contributor

@D-Walther D-Walther commented Aug 25, 2025

See #68, specifically this comment.

This PR fixes the issue described in the comment, however it comes with 2 caveats:

  • Although the documentation does not cover this behavior, I would consider this a breaking change, as any existing project using a combination of PascalCase-messages and option c.name_prefix = <something with '_'> would need to adjust to the new capitalization.
  • Given that all tests continue pass without issue, right now this behavior is clearly not covered by any test.

I'm in no position to decide how to go about this, so I'll leave that up to you. Do with this PR as you see fit.

hit9 added a commit that referenced this pull request Aug 27, 2025
@hit9 hit9 mentioned this pull request Aug 27, 2025
@hit9 hit9 merged commit fb1a5a5 into hit9:master Aug 27, 2025
10 checks passed
hit9 added a commit that referenced this pull request Aug 27, 2025
@hit9
Copy link
Owner

hit9 commented Aug 27, 2025

Thank you!

MyPrefixMyMessageType is clearly the better behavior!

Merged in #71

@hit9 hit9 mentioned this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants