Fix: type to format mapping only accepts exact match#70
Merged
hit9 merged 1 commit intohit9:masterfrom Aug 27, 2025
Merged
Conversation
- Fetching a derived type (e.g. `IntegerConstant`) resulted in no match, even if the dictionary has a value set for `Constsant`. - This made it so combining`option c.name_prefix = "lowercase_"` with `const MY_CONST = 4;` would result in `#define lowercase_MY_CONST 4`, as it would leave the capitalization untouched.
Merged
Owner
|
Thanks. Bug confirmed. Reproducible codes: Generated c files: Likewise, integer constant's capitalization is also not working for Merged into #72 |
hit9
added a commit
that referenced
this pull request
Aug 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly addresses #68.
Issue:
IntegerConstant) resulted in no match, even if the dictionary has a value forConstant.option c.name_prefix = "lowercase"withconst MY_CONST = 42;would result in#define lowercaseMY_CONST 42, as it would leave the capitalization untouched.Fix:
key's__mro__, perform a lookup of each base type and return the first (and therefore best) match.Suggestion:
Constant: "upper", howeverConstant: ("snake", "upper")seems like the more fitting option to me. Thoughts?