Implementing RFC 9234 to help with route leaks#109
Draft
Paul-weqe wants to merge 7 commits intoholo-routing:masterfrom
Draft
Implementing RFC 9234 to help with route leaks#109Paul-weqe wants to merge 7 commits intoholo-routing:masterfrom
Paul-weqe wants to merge 7 commits intoholo-routing:masterfrom
Conversation
Add the roles enum encompasing rs, rs-client, peer, customer and provider as specified in RFC 9234. Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
- introduced the role to the capability header folowing the respective RoleName enum value. - add role to NeighborConfig. This can so far be modified via the bgp::neighbors::neighbor::role::PATH. This will be changed to bgp::neighbors::neighbor::roles::role::PATH. - TryFromYang implementation for RoleName has been completed. Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
Additional items: - decoding of Capability::Role successfully. - Customized errors for BGP Role. - Verification added for allowed role correctness Specified here: https://www.rfc-editor.org/rfc/rfc9234#name-role-correctness - Add delete_apply for roles configuration. - Yang description for the role list on bgp augmentation. Discarded items: - no-role field in role. Replaced with Option<Role> in configuration. Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
- Add BGP Notification when there is a Role Mismatch. - Add remote_role to the Neighbor info. - change nbr_role naming to remote_role. - Add RoleMismatch Error Subcode. Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
- Introduce the Only To Customer (OTC) optional transitive attribute. - Move RoleName to holo-utils/bgp.rs Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
Paul-weqe
force-pushed
the
bgp-leak-prevention-rfc9234
branch
2 times, most recently
from
e20eeb4 to
fd58d38
Compare
Add BGP leak coverage mechanisms as specified in RFC 9234 Chapter 5. A few hacks added, since this requires a lot of interaction of both the attrs on the BaseAttr and the 'remote_role' field in Neighbor, some adjustments had to be made. Such hacks have been represented by 'FIXIT:' keyword. These should be removed after this commit. Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
Paul-weqe
force-pushed
the
bgp-leak-prevention-rfc9234
branch
from
fd58d38 to
f0206ca
Compare
unnecessary 'tracking' of local role removed. remote role stored at neighborcfg now Signed-off-by: Paul Wekesa <paul1tw1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9234 officially introduces the bgp roles and OTC attributes that may help in fixing route leaks.